[uss_qualifier] Remove lingering participants= in record_failed #414
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#403 removed the complexity of allowing
record_failed
invocations to override the participants specified when initiating thecheck
. However, the method I used to try and find all the existingrecord_failed
invocations that specifiedparticipants=
was not effective as I missed many places. This has caused a failure in CI for an open PR, making it more difficult to identify the root cause of that failure. This PR attempts to clean up the remaining locations.I identified the locations in this PR by searching all files for instances of
participants=
and manually evaluating each instance before removing it. I attempted to remove an instance ofparticipants=
specification only if 1) it was part of arecord_failed
invocation and 2) this argument was redundant with/identical to the participants specified when thecheck
was initiated. (side note: we had a lot of redundancy!) I did not find any instances ofrecord_failed
whereparticipants
was overridden with a different or new value from when thecheck
was initiated.I also searched for instances of
requirements=
that may have been missed in a similar way, but I did not find any.I did not perform a manual search of the 264 instances of
record_failed
we have in the codebase to identify any invocations that might have passedparticipants
positionally rather than by keyword, but I intend to keep an eye out when we remove specification ofseverity
from these invocations per #404.