Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[uss_qualifier] Remove lingering participants= in record_failed #414

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

BenjaminPelletier
Copy link
Member

#403 removed the complexity of allowing record_failed invocations to override the participants specified when initiating the check. However, the method I used to try and find all the existing record_failed invocations that specified participants= was not effective as I missed many places. This has caused a failure in CI for an open PR, making it more difficult to identify the root cause of that failure. This PR attempts to clean up the remaining locations.

I identified the locations in this PR by searching all files for instances of participants= and manually evaluating each instance before removing it. I attempted to remove an instance of participants= specification only if 1) it was part of a record_failed invocation and 2) this argument was redundant with/identical to the participants specified when the check was initiated. (side note: we had a lot of redundancy!) I did not find any instances of record_failed where participants was overridden with a different or new value from when the check was initiated.

I also searched for instances of requirements= that may have been missed in a similar way, but I did not find any.

I did not perform a manual search of the 264 instances of record_failed we have in the codebase to identify any invocations that might have passed participants positionally rather than by keyword, but I intend to keep an eye out when we remove specification of severity from these invocations per #404.

@BenjaminPelletier BenjaminPelletier merged commit 0e68bc2 into interuss:main Dec 18, 2023
9 checks passed
@BenjaminPelletier BenjaminPelletier deleted the fix-participants branch December 18, 2023 17:24
github-actions bot added a commit that referenced this pull request Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants